Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Verify correctness of using mono llvmfullaot with interpreter as a fallback instead of GSHAREDVTs #72443

Closed
wants to merge 8 commits into from
Closed

WIP: Verify correctness of using mono llvmfullaot with interpreter as a fallback instead of GSHAREDVTs #72443

wants to merge 8 commits into from

Conversation

ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Jul 19, 2022 •
edited
Loading

The following has been done:

  • AOT compiler does not force GSHAREDVT generation when running in FullInterp mode (fullAOT + interpreter)
  • Generation of GSHAREDVTs can still be instructed to the compiler by passing -O=gsharedvt ie Apple device builds are thus not affected - AOTCompiler build tasks, always include this flag:
  • Regressions regarding this change have been fixed throughout the code by running the tests built in FullInterp mode and executed with --full-aot-interp
  • IMPORTANT-NOT COMPLETE - the test infrastructure has also been altered in order to tests this change on the llvmfullaot lanes. This, however, will have to be reverted once the CI Checks finish and verify the correctness of the change. Additionally, new lanes will have to be added to test this new configuration.

This work was done according to #71482 to verify the correctness of the change.

@ivanpovazan ivanpovazan added the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 19, 2022
@ivanpovazan ivanpovazan self-assigned this Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Running CI builds to verify correctness of this change.

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

NO-REVIEW, area-Infrastructure-mono
Milestone: -

@ivanpovazan ivanpovazan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 19, 2022
@runfoapp runfoapp bot mentioned this pull request Aug 2, 2022
Closed
@ivanpovazan
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Aug 2, 2022
Open
@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Aug 3, 2022
Closed
@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Running CI builds to verify correctness of this change.

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

NO-MERGE, NO-REVIEW, area-Codegen-AOT-mono, area-Codegen-Interpreter-mono, area-Infrastructure-mono
Milestone: -

@ivanpovazan ivanpovazan removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 10, 2022
@ivanpovazan ivanpovazan changed the title WIP: Testing mono llvmfullaot with interpreter as a fallback instead of GSHAREDVTs WIP: Verify correctness of using mono llvmfullaot with interpreter as a fallback instead of GSHAREDVTs Aug 10, 2022
@ivanpovazan
Copy link
Member Author

runtime-staging failures are unrelated

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost closed this Oct 7, 2022
@ghost
Copy link

ghost commented Oct 7, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg will be requested when the pull request is marked ready for review thaystg is a code owner

Assignees

@ivanpovazan ivanpovazan

Labels
area-Codegen-AOT-mono area-Codegen-Interpreter-mono area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivanpovazan