Ensure JsonTypeInfo does not fail configuration for valid metadata originating from fast-path sourcegen #72630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsRearranges the configuration logic so that certain failure modes are surfaced at serialization time rather than configuration time. Fix #72614.
|
eiriktsarpalis
commented
Jul 21, 2022
...tem.Text.Json/src/System/Text/Json/Serialization/Converters/JsonMetadataServicesConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...tem.Text.Json/src/System/Text/Json/Serialization/Converters/JsonMetadataServicesConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...ies/System.Text.Json/src/System/Text/Json/Serialization/Metadata/SourceGenJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...ies/System.Text.Json/src/System/Text/Json/Serialization/Metadata/SourceGenJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...tem.Text.Json/src/System/Text/Json/Serialization/Converters/JsonMetadataServicesConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
...System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
Show resolved
Hide resolved
krwq
reviewed
Jul 22, 2022
krwq
approved these changes
Jul 22, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranges the configuration logic so that certain failure modes are surfaced at serialization time rather than configuration time.
Fix #72614.