[mono][interp] Make sure containing klass has field offsets initialized #73264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsFix regression from #70649. That PR exposed a case where we coincidentally initialized a class while emitting a ctor call. After the unoptimized codegen change, that newobj emit path was no longer hit. Setup the class fields explicitly when generating code that needs them.
|
vargaz
approved these changes
Aug 2, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Are these wasm failures expected ? @radical ? |
|
@BrzVlad Yes, these are on |
This was referenced Aug 3, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from #70649. That PR exposed a case where we coincidentally initialized a class while emitting a ctor call. After the unoptimized codegen change, that newobj emit path was no longer hit. Setup the class fields explicitly when generating code that needs them.
#73180