Fix JSON perf regressions reported by #73242. #73306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
|
@eiriktsarpalis interesting, I am able to reproduce it locally, it has a noticeably perf hit because these structs are quite big. |
EgorBo
reviewed
Aug 3, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs
Show resolved
Hide resolved
steveharter
approved these changes
Aug 3, 2022
|
We are seeing improvements from this change on |
|
Linux/arm64 improvement: dotnet/perf-autofiling-issues#7248 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to isolate the perf regression to using object initializer syntax in the state structs introduced in #72789. Not sure why, @EgorBo any insights?
Fix #73242.