[NativeAot] Bring up a dozen or so libraries tests #73363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time found some product issues and fixed them.
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThis time found some product issues and fixed them. Cc @dotnet/ilc-contrib
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vitek-karas
reviewed
Aug 4, 2022
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/FlowAnnotations.cs
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2022
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2022
| @@ -82,6 +84,7 @@ public static IEnumerable<object[]> CultureResourceData() | |||
|
|
|||
| [Theory] | |||
| [MemberData(nameof(CultureResourceData))] | |||
| [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))] | |||
There was a problem hiding this comment.
This issue has a new home: #69919
It would be nice to update the existing references of https://github.com/dotnet/runtimelab/issues/155 to this one.
There was a problem hiding this comment.
We can do it in one go later. 155 is a number that I don't need to look up because I remember it. 69919 is harder to remember. I often need it during bringup and I want any tiny help that makes the bringup easier. It's very tedious and repetitive.
jkotas
reviewed
Aug 4, 2022
src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 5, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time found some product issues and fixed them.
Cc @dotnet/ilc-contrib