Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests when aggressive trimming is enabled #73372

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

eiriktsarpalis
Copy link
Member

Fix #73347.

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-wasm

@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #73347.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: 7.0.0

@eiriktsarpalis eiriktsarpalis added the arch-wasm WebAssembly architecture label Aug 4, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #73347.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

arch-wasm, area-System.Text.Json

Milestone: 7.0.0

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

eiriktsarpalis and others added 2 commits August 4, 2022 15:43
…onstructorTests.ParameterMatching.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@eiriktsarpalis
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Aug 4, 2022

All failures are unrelated. The test is passing now.

@jkotas jkotas merged commit 614e763 into dotnet:main Aug 4, 2022
@eiriktsarpalis eiriktsarpalis deleted the test-disable-trimming branch August 4, 2022 18:49
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Text.Json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] Regression: System.Text.Json tests failing with trimming
2 participants