Support void* to UIntPtr parameter conversion for Invoked method #73748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
requested review from
GrabYourPitchforks,
AaronAstle,
jkotas and
steveharter
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsThere automatic type conversion takes place from Pointer (*) types to IntPtr but not for UIntPtr (throws Fixes #7430
|
jkotas
reviewed
Aug 11, 2022
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
|
Also, add the handling of this case to |
jkotas
approved these changes
Aug 11, 2022
src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There automatic type conversion takes place from Pointer (*) types to IntPtr but not for UIntPtr (throws
NotSupportedException). Whenever possible it should be able to convert to UintPtr tooFixes #7430