-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore LoopbackServer exceptions in MaxHeadersLength test #73937
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #73930
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Small suggestion.
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Outdated
Show resolved
Hide resolved
The test is failing with "inactivity" on both client and server side (console logs):
It also hit an Assert with no message that I can't find anywhere near the reported line in I don't see a reason why both sides would be hanging on this specific test. I will disable this specific test for H3 for now instead to clean up CI. |
Based on the console logs, in both cases the server is waiting on data on the control stream:
That's why everything times out, server won't reply until it read the settings frame from the control stream. The process killing Assert comes from OpenOutboundStream and is for Bidirectional stream, so it's not that. |
2a2f673
to
4426774
Compare
No-merge until the tests are actually fixed
😆 |
Note |
The SUCCESS status comes from this line: |
This is the first time I've seen that specific failure. |
I am trying to setup alpine wsl so I can take a look at the dump, but the source suggests that we receive the success status from MsQuic |
Assert should be fixed by #74348 |
Not getting much use out of running CI here, closing for now. |
Fixes #73930