Directory.CreateDirectory: create missing parents using default UnixFileMode. #74002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFixes #73899. @jozkee @adamsitnik @eerhardt @dotnet/area-system-io ptal.
|
jozkee
reviewed
Aug 16, 2022
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 16, 2022
jozkee
reviewed
Aug 16, 2022
src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory_UnixFileMode.Unix.cs
Show resolved
Hide resolved
carlossanlop
approved these changes
Aug 17, 2022
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jozkee
reviewed
Aug 17, 2022
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.File.Tests.cs
Outdated
Show resolved
Hide resolved
|
There are test failures in runtime-extra-platforms and they seem related to this PR. Note: In case you don't know how to retrieve the logs for mobile platforms, here are instructions: Instructions
Example:
All the failures seem to be the same for the 4 CI legs where they showed up:
The tests fail here: Callstacks |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jozkee
approved these changes
Aug 18, 2022
|
I'm going to make another change here based on the discussion with @jozkee (#74002 (comment)).
|
tmds
changed the title
tmds
changed the title
|
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jozkee
reviewed
Aug 19, 2022
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jozkee
approved these changes
Aug 19, 2022
src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.File.Tests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
-79
to
-80
| // Apply permissions to an existing directory when we're overwriting metadata | ||
| // or the directory was created as a missing parent (stored in pendingModes). |
There was a problem hiding this comment.
If the directory existed prior to TarFile.ExtractToDirectory(), with overwrite:false we don't throw exception? Documentation for overwriteFiles param says otherwise:
true to overwrite files and directories in destinationDirectoryName; false to avoid overwriting, and throw if any files or directories are found with existing names.
There was a problem hiding this comment.
Yes.
The behavior is the same as tar. When not passing the --overwrite flag, t doesn't give an error when extracting a directory that already exists, and it does set the mode of that directory.
| const UnixFileMode ExtractPermissions = UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute; | ||
|
|
||
| Debug.Assert(pendingModes is not null); | ||
|
|
||
| if (Directory.Exists(fullPath)) | ||
| { | ||
| // Apply permissions to an existing directory when we're overwriting metadata | ||
| // or the directory was created as a missing parent (stored in pendingModes). | ||
| // Apply permissions to an existing directory. | ||
| if (mode.HasValue) |
There was a problem hiding this comment.
I know tar overwrites metadata for existing directories by default, but it feels counterintuitive for our API to do that when overwriteFiles is false. I really don't know what's best here.
Suggested change
| if (mode.HasValue) | |
| if (mode.HasValue && overwriteMetadata) |
There was a problem hiding this comment.
tar has this behavior.
--overwrite
Overwrite existing files when extracting.
--overwrite-dir
Overwrite metadata of existing directories when extracting (default).
--overwrite control in .NET is through overwrite.
.NET doesn't have an arg for --overwrite-dir but the behavior matches with the tar default.
I think we're good.
|
I pushed the whitespace change before the Android platforms ran and they got cancelled. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
CI issues on extra-platforms are not related to System.Formats.Tar nor System.IO.Directory. |
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2892175875 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73899.
@jozkee @adamsitnik @eerhardt @dotnet/area-system-io ptal.