Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Use new javascript API in tests and samples #74153

Merged
merged 6 commits into from
Aug 22, 2022
Merged

[wasm] Use new javascript API in tests and samples #74153

merged 6 commits into from
Aug 22, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 18, 2022 •
edited by pavelsavara
Loading

  • Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
  • Add guard in withApplicationArgumentsFromQuery for window object.

Contributes to #72990

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Aug 18, 2022
@maraf maraf self-assigned this Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
  • Add guard in withApplicationArgumentsFromQuery for window object.
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: -

@maraf
Copy link
Member Author

maraf commented Aug 18, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf changed the title [wasm] Use mew javascript API in tests and samples [wasm] Use new javascript API in tests and samples Aug 18, 2022
@maraf
Copy link
Member Author

maraf commented Aug 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf merged commit 8cf96d9 into dotnet:main Aug 22, 2022
@maraf maraf deleted the WasmJsApiPart2 branch August 22, 2022 14:47
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @pavelsavara