Update Microsoft.CodeAnalysis.CSharp.CodeStyle package #74445
Conversation
Update the Microsoft.CodeAnalysis.CSharp.CodeStyle package to the .NET 7 Preview 7 version and fix the various failures.
jkoritzinsky
requested review from
lewing,
pavelsavara,
thaystg,
radical,
marek-safar and
MichalStrehovsky
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsUpdate the Microsoft.CodeAnalysis.CSharp.CodeStyle package to the .NET 7 Preview 7 version and fix the various failures.
|
| if (func == null) | ||
| { | ||
| func = s_GetTempPathWFunc = GetGetTempPathWFunc(); | ||
| } | ||
| #pragma warning restore IDE0074 |
There was a problem hiding this comment.
Can we make sure there's an open issue in dotnet/roslyn for this? The analyzer shouldn't fire for function pointers unless ??= can be used with function pointers.
There was a problem hiding this comment.
I need to check this one again, but I think the reason I didn't want to use the fix was for clarity around the call to GetGetTempPathWFunc(). I'll try using ??= here and see if it works for function pointers.
There was a problem hiding this comment.
I'll try using ??= here and see if it works for function pointers.
I don't believe it does.
There was a problem hiding this comment.
You are correct. It does not work for function pointers. I'll open an issue.
| @@ -95,6 +95,7 @@ private static void InitFCN() | |||
| { | |||
| fcn = host.GetService(typeof(IFileChangeNotificationSystem)) as IFileChangeNotificationSystem; | |||
| } | |||
| #pragma warning disable IDE0074 // Use compound assignment | |||
There was a problem hiding this comment.
I think there should also be a dotnet/roslyn issue for this. It shouldn't be recommending compound assignment if there are ifdefs in the way.
| // Let the InternalTransaciton know about the outcome. | ||
| if (InternalTransaction != null) | ||
| { | ||
| InternalTransaction.DistributedTransactionOutcome(InternalTransaction, Status); | ||
| } | ||
|
|
||
| #pragma warning restore IDE0031 |
There was a problem hiding this comment.
Why does this one need to be suppressed rather than:
InternalTransaction?.DistributedTransactionOutcome(InternalTransaction, Status);?
There was a problem hiding this comment.
The method DistributedTransactionOutcome is a static method. InternalTransaction is the name of both a property and the type of that property. Fixing this to use ?. changes the invocation to try to invoke an instance method on the InternalTransaction property value instead of the InternalTransaction type.
This one definitely deserves a Roslyn issue.
There was a problem hiding this comment.
Ah, then yeah, that's a bug.
Update the Microsoft.CodeAnalysis.CSharp.CodeStyle package to the .NET 7 Preview 7 version and fix the various failures.