Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable SendMailAsync_CanBeCanceled_CancellationToken test #74545

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 25, 2022

contributes to #73447

I could not reproduce it. so I'm enabling the test again with limit on execution.
If something fails we should not hang the whole suite and hopefully we would get some insight.
I can instrument the test more if we see failures.

@wfurt wfurt requested a review from a team August 25, 2022 04:00
@wfurt wfurt self-assigned this Aug 25, 2022
@ghost
Copy link

ghost commented Aug 25, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #73447

I could not reproduce it. so I'm enabling the test again with limit on execution.
If something fails we should not hang the whole suite and hopefully we would get some insight.
I can instrument the test more if we see failures.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm
Copy link
Member

rzikm commented Aug 25, 2022

Also related to #72830, since it is the same test.

@wfurt
Copy link
Member Author

wfurt commented Aug 25, 2022

test failure is #73688.

@wfurt wfurt merged commit 8ba720c into dotnet:main Aug 25, 2022
@wfurt wfurt deleted the cancelMail branch August 25, 2022 16:13
@karelz karelz added this to the 8.0.0 milestone Aug 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants