Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable nullability warnings in JSON source generator #74801

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Disable nullability warnings in JSON source generator #74801

merged 2 commits into from
Aug 31, 2022

Conversation

krwq
Copy link
Member

@krwq krwq commented Aug 30, 2022 •
edited
Loading

Fixes: #74652
Fixes: #61734

@krwq krwq requested a review from eiriktsarpalis August 30, 2022 10:15
@ghost ghost assigned krwq Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #74652

Author: krwq
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis
Copy link
Member

Fixes: #74652

We should probably not close this (or #61734) with this PR since we're merely suppressing warnings -- the underlying problem remains and we probably need to fix it in the future.

eiriktsarpalis
eiriktsarpalis approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krwq krwq merged commit 6294858 into dotnet:main Aug 31, 2022
@eiriktsarpalis eiriktsarpalis mentioned this pull request Aug 31, 2022
Open
@eiriktsarpalis
Copy link
Member

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2962426947

@krwq
Copy link
Member Author

krwq commented Aug 31, 2022

You beat me with port as I was trying to find out what syntax that command has 😄

@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@krwq krwq

Labels
area-System.Text.Json
Projects
None yet
Milestone
8.0.0
2 participants
@krwq @eiriktsarpalis