Reuse more Microsoft.Interop.SourceGeneration code in JS generators #74949
Conversation
jkoritzinsky
added
area-System.Runtime.InteropServices.JavaScript
source-generator
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
the wasm built test failures are likely from #74897 @ericstj @danmoseley can you verify? |
|
Yes: That's been fixed now, we can retrigger the pipeline. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…SourceGeneration.GeneratedStatements and ContainingSyntaxContext types.
…cating the logic.
jkoritzinsky
force-pushed
the
pinned-marshal-jsgen
branch
from
99a95ea
to
5c8eaa3
Compare
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
| AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(GeneratorVersion))) | ||
| })))))); | ||
| } | ||
| string stubTypeFullName = method.ContainingType.ToDisplayString(new SymbolDisplayFormat(typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces)); |
There was a problem hiding this comment.
NameAndContainingTypesAndNamespaces is better than what we have in the GetFullyQualifiedMethodName and s_typeNameFormat, please unify it.
There was a problem hiding this comment.
If we use NameAndContainingTypesAndNamespaces in GetFullyQualifiedMethodName, how do we determine which "." separate class names and which namespace names?
Context: mono special naming convention requires to separate class names with / and namespaces with '.'.
There was a problem hiding this comment.
I think to meet the Mono naming requirements with NameAndContainingTypesAndNamespaces would require us to go back to using ToDisplayParts(). I'll leave that for now since we just moved away from that.
...ies/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSExportCodeGenerator.cs
Show resolved
Hide resolved
...es/System.Runtime.InteropServices/gen/LibraryImportGenerator/DefaultMarshallingInfoParser.cs
Outdated
Show resolved
Hide resolved
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Reuse more of the code in Microsoft.Interop.SourceGeneration in the JavaScript source generators instead of duplicating the logic.
Refactor the JavaScript generators to use the GeneratedStatements type instead of providing its own JSGeneratedStatements type.
Refactor the JSSignatureContext type to wrap a SignatureContext instead of providing a very similar surface area with a lot of duplicated code.
This PR also enhances the API surface of types in Microsoft.Interop.SourceGeneration to enable these sorts of scenarios.