-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Use the register of CAST for contained index operator #75145
[release/7.0] Use the register of CAST for contained index operator #75145
Conversation
* Rename test files * Fix index scale for cast * Do not contain index if indir is not containable. * Revert "Do not contain index if indir is not containable." This reverts commit e79d17d92ceb0eed5ae1bfd03c2d1d6b171ab17f. * Instead try to contain the LEA * IsSafeToContainMem() check * Do IsSafeToContainMem() only if needed * Add test case * Fix merge error * fix the test case * review comment
@dotnet/jit-contrib |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIf index is contained and the underlying operator is GT_CAST we were not handling that case and that led to using REG_COUNT register from index in genScaledAdd() . I have fixed it and also added checks to see if more such cases are missing. Fixes: #74117
|
@BruceForstall can we get a code review sign off? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. once we get a green ci we can merge.
There were a ton of llvmaot failures. Are they related to this change? All failed with the same error code:
|
Original PR didn't had those. The failure seems very fundamental that it failed to initialize coreclr. May be rerun? |
@jkotas @MichalStrehovsky do the above llvmaot failures look familiar to you? Should I open an issue? I am unsure if any of the open issues with that error number is the same: https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+0x80004005 |
llvmaot is Mono. Looks like #72114. Cc @lambdageek @SamMonoRT |
Approved and signed off. |
Backport of #74275
If index is contained and the underlying operator is GT_CAST we were not handling that case and that led to using REG_COUNT register from index in genScaledAdd() . I have fixed it and also added checks to see if more such cases are missing.
Fixes: #74117