-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify AsnDecoder.ReverseBitsPerByte #75301
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsUsing the same bit twiddling hack as Lines 244 to 248 in cc9d465
|
Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @vcsjones Issue DetailsUsing the same bit twiddling hack as Lines 244 to 248 in cc9d465
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not common enough for a public method
Failure is #75329 |
I wouldn't be adverse to a: public static class BitOperations
{
+ public static byte ReverseBits(byte value);
} but I don't know it's valuable enough to be warranted. |
Using the same bit twiddling hack as
runtime/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/ManagedX509ExtensionProcessor.cs
Lines 244 to 248 in cc9d465