Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RIDs for macOS 13 #75371

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add RIDs for macOS 13 #75371

merged 1 commit into from
Sep 12, 2022

Conversation

filipnavara
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2022
@filipnavara filipnavara mentioned this pull request Sep 9, 2022
Merged
am11
am11 reviewed Sep 10, 2022
View reviewed changes
Copy link
Member

@am11 am11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please run dotnet build src/libraries/Microsoft.NETCore.Platforms -p:UpdateRuntimeFiles=true task which sorts the RID graph values.

@ghost
Copy link

ghost commented Sep 10, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution
Milestone: -

@am11 am11 requested a review from wfurt September 10, 2022 01:29
@filipnavara
Copy link
Member Author

Looks good. Please run dotnet build src/libraries/Microsoft.NETCore.Platforms -p:UpdateRuntimeFiles=true task which sorts the RID graph values.

Haha. That would have saved me some manual edits if I did it in the first place... Turns out I made cut and paste error though.

@jkotas
Copy link
Member

jkotas commented Sep 11, 2022

@danmoseley I assume that we want to take this change for .NET 7. Have we done any scouting on macOS 13? It will releases in October.

@filipnavara filipnavara marked this pull request as ready for review September 11, 2022 21:23
@wfurt
Copy link
Member

wfurt commented Sep 11, 2022

I have VM and I was planning to run tests when I get some more time. Probably next week @jkotas

@jkotas jkotas merged commit 855c475 into dotnet:main Sep 12, 2022
@jkotas
Copy link
Member

jkotas commented Sep 12, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3033947818

@github-actions github-actions bot mentioned this pull request Sep 12, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@jkotas jkotas jkotas approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees
No one assigned
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filipnavara @jkotas @wfurt @am11