-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RID for alpine-3.17 + alpine-{armv6,x86,s390x,ppc64le} #75396
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsAdds RID for Alpine 3.17 + all arches that both runtime and alpine can target for eventual port. Contributes to dotnet/core#7684
|
072f6d6
to
dff46ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me. since are are adding new architecture instead of just adding updated release I added few more people for comments.
I was wondering if we should fork the rid but it seems like we retro fit new architectures elsewhere to older releases as well.
"alpine-armv6": { | ||
"#import": [ | ||
"alpine", | ||
"linux-musl-armv6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it was not obvious, armv6 is only supported with mono runtime. From coreclr, we only build PAL, HP libunwind among few other pieces to support corehost (dotnet(1)
) with -p:RuntimeFlavor=mono
.
If this is working on Alpine Linux, I think would be nice to add a CI leg for linux-musl-armv6
in extra-platforms pipeline (it may need some extra work in our cross infra setup). If this is untested, I think we should skip armv6
for now.
cc @akoeplinger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mono is currently broken on musl due to using libc symbols, but I'm in the process of fixing it for s390x
and armv6
.
Adds RID for Alpine 3.17 + all arches that both runtime and alpine can target for eventual port.
Contributes to dotnet/core#7684
Contributes to dotnet/source-build#2839
Contributes to dotnet/source-build#3020