Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RID for alpine-3.17 + alpine-{armv6,x86,s390x,ppc64le} #75396

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Sep 10, 2022

Adds RID for Alpine 3.17 + all arches that both runtime and alpine can target for eventual port.

Contributes to dotnet/core#7684
Contributes to dotnet/source-build#2839
Contributes to dotnet/source-build#3020

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 10, 2022
@ghost
Copy link

ghost commented Sep 10, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds RID for Alpine 3.17 + all arches that both runtime and alpine can target for eventual port.

Contributes to dotnet/core#7684
Contributes to dotnet/source-build#2839
Contributes to dotnet/source-build#3020

Author: ayakael
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@ayakael ayakael changed the title Add RID for alpine-3.17 + alpine-{armv6,x86,s390x,ppc64le) Add RID for alpine-3.17 + alpine-{armv6,x86,s390x,ppc64le} Sep 10, 2022
@ayakael ayakael force-pushed the alpine/arch-rid branch 2 times, most recently from 072f6d6 to dff46ed Compare September 11, 2022 00:37
ayakael added a commit to ayakael/runtime that referenced this pull request Sep 13, 2022
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me. since are are adding new architecture instead of just adding updated release I added few more people for comments.

I was wondering if we should fork the rid but it seems like we retro fit new architectures elsewhere to older releases as well.

"alpine-armv6": {
"#import": [
"alpine",
"linux-musl-armv6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it was not obvious, armv6 is only supported with mono runtime. From coreclr, we only build PAL, HP libunwind among few other pieces to support corehost (dotnet(1)) with -p:RuntimeFlavor=mono.

If this is working on Alpine Linux, I think would be nice to add a CI leg for linux-musl-armv6 in extra-platforms pipeline (it may need some extra work in our cross infra setup). If this is untested, I think we should skip armv6 for now.

cc @akoeplinger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mono is currently broken on musl due to using libc symbols, but I'm in the process of fixing it for s390x and armv6.

@jkotas jkotas merged commit b707fd6 into dotnet:main Sep 15, 2022
vseanreesermsft pushed a commit to vseanreesermsft/runtime that referenced this pull request Oct 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants