Disallow TimeSpan.Zero in rate limiters #75496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @mangod9 Issue DetailsForward port of change in release/7.0 from #74971
|
stephentoub
reviewed
Sep 19, 2022
...es/System.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 19, 2022
| @@ -71,6 +71,15 @@ public override void InvalidOptionsThrows() | |||
| Window = TimeSpan.FromMinutes(-2), | |||
| AutoReplenishment = false, | |||
| })); | |||
| Assert.Throws<ArgumentException>( | |||
There was a problem hiding this comment.
Ideally all of these Assert.Throws would instead be AssertExtensions.Throws and have a first argument that's the name of the argument we expect is being flagged as invalid.
There was a problem hiding this comment.
Wasn't aware of those extensions 👍
stephentoub
approved these changes
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of change in release/7.0 from #74971