WIP Separate platform & target #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdmaclea
force-pushed
the
SeparatePlatformTarget
branch
from
e2092f9
to
27f8437
Compare
|
@sdmaclea it is not clear to me how we can ever build native components cross os, can you please share more details on how are we planning to do that? |
|
@janvorli This work is experimental at this point. |
sdmaclea
commented
Dec 11, 2019
src/coreclr/build.cmd
Outdated
| @@ -128,6 +128,8 @@ if /i "%1" == "-x86" (set __BuildArchX86=1&set processedArgs=!pr | |||
| if /i "%1" == "-arm" (set __BuildArchArm=1&set processedArgs=!processedArgs! %1&shift&goto Arg_Loop) | |||
| if /i "%1" == "-arm64" (set __BuildArchArm64=1&set processedArgs=!processedArgs! %1&shift&goto Arg_Loop) | |||
|
|
|||
| if /i "%1" == "-linux" (set __BuildOS=Linux&set processedArgs=!processedArgs! %1&shift&goto Arg_Loop) | |||
There was a problem hiding this comment.
This option may imply general support. Maybe a special purpose flag would be better.
Make FEATURE_PAL depend on the platform
sdmaclea
force-pushed
the
SeparatePlatformTarget
branch
from
4004cba
to
dd5c3ef
Compare
Move the Crst member to the end of the structure for the cross OS DAC.
Remove multiple inheritance by dropping noncopyable This corrects the layout of the SHash structure on Windows to match Linux. The multiple inheritance was in serting an extra byte of padding in the structure layout.
sdmaclea
force-pushed
the
SeparatePlatformTarget
branch
from
dd5c3ef
to
aeadc93
Compare
|
This prototype worked, but this code needs to be polished before merging. Closing this in favor of smaller actionable PRs. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend cross component build make system to allow cross OS build for some components.
Standardize on
PlatformandTargetfor the nomenclature (rename_Host_to_Platform_)Add
CLR_CMAKE_TARGET_*Modify feature flag definition to depend on
CLR_CMAKE_TARGET_*Modify crosscomponent make to handle
CLR_CMAKE_TARGET_OSSet
CLR_CMAKE_TARGET_OSin build.cmdAdd flag to set target OS to linux.
Remove stray sos reference