Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IDispatchImplAttribute API #76416

Merged
merged 3 commits into from
Oct 1, 2022
Merged

Remove IDispatchImplAttribute API #76416

merged 3 commits into from
Oct 1, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

This type has never been supported on .NET Core.
Removing all supporting code paths.

@AaronRobinsonMSFT
Remove IDispatchImplAttribute API
0881055 
This type has never been supported on .NET Core.
Removing all supporting code paths.
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This type has never been supported on .NET Core.
Removing all supporting code paths.

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices
Milestone: 8.0.0

@AaronRobinsonMSFT
Copy link
Member Author

Failure is #76429

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 26a91ad into dotnet:main Oct 1, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_idispatchimplattr branch October 1, 2022 00:04
@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2022
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Aug 16, 2023
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 16, 2023
@ericstj
Copy link
Member

ericstj commented Aug 16, 2023 •
edited
Loading

Looks like this type was previously exposed via the .NETFramework compat shim for mscorlib.dll. We should write up a breaking change doc on this on the off chance someone needed it. See #90578, #90669

@AaronRobinsonMSFT
Copy link
Member Author

BCN: dotnet/docs#36729

@AaronRobinsonMSFT AaronRobinsonMSFT removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-System.Runtime.InteropServices breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronRobinsonMSFT @ericstj @jkoritzinsky @elinor-fung