System.Private.Xml AOT compatibility fixes #76473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jkoritzinsky
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/area-system-xml Issue DetailsAdd some annotations for ILC as discovered in #75793
|
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsAdd some annotations for ILC as discovered in #75793
|
jkotas
reviewed
Oct 1, 2022
| @@ -1088,6 +1089,8 @@ internal override RestrictionFlags ValidRestrictionFlags | |||
| return exception; | |||
| } | |||
|
|
|||
| [UnconditionalSuppressMessage("AotAnalysis", "IL3050:AotUnfriendlyApi", | |||
| Justification = "All types that are instantiated with this method are used elsewhere in this file in the implementations of the DatatypeImplementation abstract class.")] | |||
There was a problem hiding this comment.
I assume that this warning is about values.ToArray(_itemType.ValueType). I think it works, but it fragile and hard to see that it is correct.
I would suggest factoring out the code that produces the Aot warning into a local method, apply the warning onto the local method only, and use the array type to create the array to guarantee that it is kept. Something like:
array = CreateArray(ListValueType);
values.CopyTo(array, 0);
...
[UnconditionalSuppressMessage("AotAnalysis", "Array type is passed as an argument to this method, so it is guaranteed to exist.")]
static Array CreateArray(Type arrayType, int length)
{
Array array = Array.CreateInstance(arrayType.GetElementType()!, length);
Debug.Assert(array.GetType() == arrayType);
return array;
}There was a problem hiding this comment.
Opened #76478 to make this better.
jkotas
reviewed
Oct 1, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlValueConverter.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Oct 1, 2022
src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHandler.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 3, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eerhardt
reviewed
Oct 3, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlValueConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlValueConverter.cs
Show resolved
Hide resolved
jkoritzinsky
commented
Oct 3, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlValueConverter.cs
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
jkotas
approved these changes
Oct 3, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Oct 3, 2022
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
Outdated
Show resolved
Hide resolved
…eImplementation.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some annotations for ILC as discovered in #75793