Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check handles in substitution #76730

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Don't check handles in substitution #76730

merged 2 commits into from
Oct 18, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Oct 6, 2022 •
edited
Loading

This should principally not be necessary after the recent RETURN-related changes.

Some CQ improvements are expected.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 6, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 6, 2022
@ghost
Copy link

ghost commented Oct 6, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This should principally not be necessary after the recent RETURN-related changes, but let's see what CI thinks.

Some CQ improvements are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review October 7, 2022 13:16
@SingleAccretion
Copy link
Contributor Author

SPMI failures are due to the lack of win-arm64 MCHs.

@dotnet/jit-contrib

Would be good run [libraries-]stress over this.

@jakobbotsch
Copy link
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Oct 7, 2022
Closed
@SingleAccretion
Copy link
Contributor Author

Looks like there is at least one stress failure that needs to be investigated.

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Oct 7, 2022 •
edited
Loading

The stress failure has been fixed.

Libraries stress failures looked preexisting (point of reference).

AndyAyersMS
AndyAyersMS approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndyAyersMS
Copy link
Member

Failures look like CI issues:

      NuGet.Protocol.Core.Types.FatalProtocolException : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json.

Will retry once the arm64 tests finish.

@build-analysis build-analysis bot mentioned this pull request Oct 8, 2022
Closed
2 tasks
@build-analysis build-analysis bot mentioned this pull request Oct 10, 2022
Closed
@AndyAyersMS
Copy link
Member

NAOT failure is a known issue.

@AndyAyersMS AndyAyersMS merged commit 7ac397e into dotnet:main Oct 18, 2022
@AndyAyersMS
Copy link
Member

Thank you for your ongoing contributions.

This was referenced Oct 20, 2022
Closed
Closed
Closed
@SingleAccretion SingleAccretion deleted the FwdSub-Relaxations-Upstream branch October 22, 2022 17:30
@EgorBo EgorBo mentioned this pull request Nov 10, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @jakobbotsch @AndyAyersMS