Use IndexOfAny{Except}InRange in RegexCompiler / source generator

[stephentoub]

Depends on #76803.

This augments our existing use of IndexOf, IndexOfAny, and IndexOfAnyExcept to also support IndexOfAnyInRange and IndexOfAnyExceptInRange. That means, for example, we can now efficiently find the start of a pattern like [0-9]{5}, via a vectorized search, whereas previously it'd require iterating character by character in a scalar loop.

As part of this, I changed some tuples to instead be named structs. They were becoming unwieldy, and we expect we'll be adding even more here as additional IndexOf variants become available.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Depends on #76803.

This augments our existing use of IndexOf, IndexOfAny, and IndexOfAnyExcept to also support IndexOfAnyInRange and IndexOfAnyExceptInRange. That means, for example, we can now efficiently find the start of a pattern like [0-9]{5}, via a vectorized search, whereas previously it'd require iterating character by character in a scalar loop.

As part of this, I changed some tuples to instead be named structs. They were becoming unwieldy, and we expect we'll be adding even more here as additional IndexOf variants become available.

Author:	stephentoub
Assignees:	-
Labels:	area-System.Text.RegularExpressions, tenet-performance
Milestone:	8.0.0

[joperezr]

I assume the tests we have currently exercise this code already for both source generator and compiled engine.

Left a few nits, but this otherwise LGTM assuming CI will be green once the change in System.Memory goes in.

[joperezr]

BTW, just curious, did you happen to run our perf tests to measure any gains that we might have gotten from this?

[stephentoub]

BTW, just curious, did you happen to run our perf tests to measure any gains that we might have gotten from this?

I didn't. I don't think any of our perf tests have patterns impacted by this. I'll pay attention to any improvements/regression reports, though, in case one slips through.

[stephentoub]

I assume the tests we have currently exercise this code already for both source generator and compiled engine.

Yup. Though I added a few more tests to cover a few gaps.

[AndyAyersMS]

Improvements:

• [Perf] Windows/arm64: 1 Improvement on 10/27/2022 5:53:52 AM perf-autofiling-issues#9475