Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Unix dependencies installation script #77107

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Oct 17, 2022

  • Use version-less llvm toolchain on Debian/Ubuntu (Use current version of clang and llvm in Linux prereqs #74811).
  • Allow case insensitive OS name (eng/install-native-dependencies.sh macos # or osx).
  • Check if distro is Debian or its derivative (apt is a Debian thing).
  • Remove sudo to make it work with root (e.g. in a docker container); non-root will get a (readable) error from the system, when higher privileges are needed.
  • Fix shellcheck errors and lower the dependency to Unix/Bourne shell script (we were using mixed syntax, now it is unified).

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use version-less llvm toolchain on Debian/Ubuntu (Use current version of clang and llvm in Linux prereqs #74811).
  • Allow case insensitive OS name (eng/install-native-dependencies.sh macos # or osx).
  • Check if distro is Debian or its derivative (apt is a Debian thing).
  • Remove sudo to make it work with root (e.g. in a docker container); non-root will get a (readable) error from the system, when higher privileges are needed.
  • Fix shellcheck errors and lower the dependency to Unix/Bourne shell script (we were using mixed syntax, now it is unified).
Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton 🤘

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants