Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Template nits 2 #77263

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Oct 20, 2022

Backport of #77205 to release/7.0

Customer Impact

Better worded readme

Testing

Manual

Risk

None

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Oct 20, 2022
@maraf maraf added this to the 7.0.0 milestone Oct 20, 2022
@ghost ghost assigned maraf Oct 20, 2022
@ghost
Copy link

ghost commented Oct 20, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #77205 to release/7.0

Customer Impact

Better worded readme

Testing

Manual

Risk

None

Author: maraf
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.0

@lewing lewing modified the milestones: 7.0.0, 7.0.x Oct 20, 2022
@carlossanlop
Copy link
Member

@maraf @radical is this fix customer facing or can be consider it infra only / tell-mode?
There were browser failures BTW. Do any of them look related to this?

@radical
Copy link
Member

radical commented Oct 25, 2022

The browser failures are not related. The changes should be benign, but they are customer facing.

@carlossanlop
Copy link
Member

Tell mode. Signed off. CI failure is unrelated and was fixed in this other PR: #76939 so it's not worth retriggering the whole CI for it.

@carlossanlop carlossanlop merged commit 530976e into dotnet:release/7.0 Nov 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
@maraf maraf deleted the WasmTemplateNits2on70 branch June 21, 2024 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants