-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce FIELD_ADDR
and use it for TLS statics and instance class fields
#77353
Merged
jakobbotsch
merged 16 commits into
dotnet:main
from
SingleAccretion:Field-Addr-Upstream
Nov 10, 2022
Merged
Introduce FIELD_ADDR
and use it for TLS statics and instance class fields
#77353
jakobbotsch
merged 16 commits into
dotnet:main
from
SingleAccretion:Field-Addr-Upstream
Nov 10, 2022
Commits on Oct 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 95268ce - Browse repository at this point
Copy the full SHA 95268ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2424bd - Browse repository at this point
Copy the full SHA f2424bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3275205 - Browse repository at this point
Copy the full SHA 3275205View commit details -
Implement Windows x86 TLS via FIELD_ADDR
Tested manually to work as well as it did before.
Configuration menu - View commit details
-
Copy full SHA for 042342a - Browse repository at this point
Copy the full SHA 042342aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab0774b - Browse repository at this point
Copy the full SHA ab0774bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0693d11 - Browse repository at this point
Copy the full SHA 0693d11View commit details
Commits on Oct 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3d9b5bc - Browse repository at this point
Copy the full SHA 3d9b5bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16fb23c - Browse repository at this point
Copy the full SHA 16fb23cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b621b7b - Browse repository at this point
Copy the full SHA b621b7bView commit details -
With NativeAOT, we can have FIELD_ADDR nodes that are effectively NOPs (those for the method table pointer field). This means not all operators that the expansion produces will be simple (in fact, they can be more or less arbitrary). This means we cannot simply call "fgMorphSmpOp" as we used to. Unfortunately, we cannot just call "fgMorphTree" either, because it propagates assertions on newly created (or, I suppose, bashed) IND nodes. This creates lots of new cases where GTF_ORDER_SIDEEFF is applied to these nodes, affecting CQ. Work around this by calling "fgMorphTree" for non-simple operators only.
Configuration menu - View commit details
-
Copy full SHA for 52ef7a6 - Browse repository at this point
Copy the full SHA 52ef7a6View commit details
Commits on Oct 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for eb427c5 - Browse repository at this point
Copy the full SHA eb427c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5396d3 - Browse repository at this point
Copy the full SHA f5396d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 778cf2b - Browse repository at this point
Copy the full SHA 778cf2bView commit details
Commits on Nov 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 24d7439 - Browse repository at this point
Copy the full SHA 24d7439View commit details
Commits on Nov 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b752ecf - Browse repository at this point
Copy the full SHA b752ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d611c - Browse repository at this point
Copy the full SHA 37d611cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.