-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Define __cpuid{ex} only when there's no builtin one (backport of #73065) #77507
[release/6.0] Define __cpuid{ex} only when there's no builtin one (backport of #73065) #77507
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
There was a problem in this patch with old gcc versions. It was fixed in #73905. |
b763366
to
b94f3b5
Compare
@jkotas I see you approved the |
b94f3b5
to
034e51d
Compare
Tagging subscribers to this area: @hoyosjs Issue DetailsPer @am11:
Customer impactWithout this, build with clang15 fails. Testing
RiskLow, as it is already in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 6.0.x
The CI failure is weird, because the test is supposed to be disabled (it was disabled here): Line 94 in 2a65e07
Aside from that, the CI is green, it was approved by Tactics, signed off by area owner, and does not need OOB package authoring changes (it's native code). Ready to merge. |
Ah, this is 6.0, I thought this was 7.0, that's why we're hitting it here too. I'll backport the ActiveIssue change. |
Customer impact
Without this, build with clang15 fails.
Testing
Risk
Low, as it is already in
main
, and only activates when these variables aren't definedBackport of #73065 and #73905
Per @am11: