[wasm][libs] Fix `WasmAppHost`, and `AppBundle` for library tests #77719

ilonatommy · 2022-11-01T13:33:46Z

Partial fix for #76721.

This PR fixes running lib tests e.g.

dotnet run -r browser-wasm -c Debug --project src/libraries/System.Linq/tests/System.Linq.Tests.csproj --debug --host browser -p:DebuggerSupport=true

results in:

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.29
WasmAppHost --runtime-config runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle\WasmTestRunner.runtimeconfig.json --debug --host browser
Debug proxy for chrome now listening on http://127.0.0.1:65095/. And expecting chrome at http://localhost:9222/
Hosting environment: Production
Content root path: runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle
Now listening on: http://127.0.0.1:65095
Debug proxy for firefox now listening on tcp://127.0.0.1:65096. And expecting firefox at port 6000 .

App url: http://127.0.0.1:9000/index.html
App url: https://127.0.0.1:50493/index.html

Scenarios from #75384 description got tested and work.

How it works:

ghost · 2022-11-01T13:33:56Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial fix for #76721.
Sets the paths right, so that running e.g.

dotnet run -r browser-wasm -c Debug --project src/libraries/System.Linq/tests/System.Linq.Tests.csproj --debug --host browser -p:DebuggerSupport=true

results in:

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.29
WasmAppHost --runtime-config C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle\WasmTestRunner.runtimeconfig.json --debug --host browser
Debug proxy for chrome now listening on http://127.0.0.1:65095/. And expecting chrome at http://localhost:9222/
Hosting environment: Production
Content root path: C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle
Now listening on: http://127.0.0.1:65095
Debug proxy for firefox now listening on tcp://127.0.0.1:65096. And expecting firefox at port 6000 .

App url: http://127.0.0.1:9000/index.html
App url: https://127.0.0.1:65097/index.html

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Infrastructure-libraries`
Milestone:	-

ghost · 2022-11-01T13:34:07Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial fix for #76721.
Sets the paths right, so that running e.g.

dotnet run -r browser-wasm -c Debug --project src/libraries/System.Linq/tests/System.Linq.Tests.csproj --debug --host browser -p:DebuggerSupport=true

results in:

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.29
WasmAppHost --runtime-config C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle\WasmTestRunner.runtimeconfig.json --debug --host browser
Debug proxy for chrome now listening on http://127.0.0.1:65095/. And expecting chrome at http://localhost:9222/
Hosting environment: Production
Content root path: C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle
Now listening on: http://127.0.0.1:65095
Debug proxy for firefox now listening on tcp://127.0.0.1:65096. And expecting firefox at port 6000 .

App url: http://127.0.0.1:9000/index.html
App url: https://127.0.0.1:65097/index.html

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Infrastructure-libraries`
Milestone:	-

ilonatommy · 2022-11-01T17:11:49Z

It needs more investigation, some tests WBT are failing with

An error occurred trying to start process '/datadisks/disk1/work/B23E09A6/w/B0E30929/e/dotnet-net7+latest/dotnet' with working directory '/datadisks/disk1/work/B23E09A6/w/B0E30929/e/wbt/Release_natwm0cn.rf0/bin/Release/net7.0/AppBundle'. No such file or directory.

radical · 2022-11-01T17:16:46Z

The app bundle path is incorrect - /datadisks/disk1/work/B23E09A6/w/B0E30929/e/wbt/Debug_g1z0cnbw.fta/bin/Debug/net7.0/browser-wasm/AppBundle/ vs /datadisks/disk1/work/B23E09A6/w/B0E30929/e/wbt/Debug_g1z0cnbw.fta/bin/Debug/net7.0/AppBundle.

ghost · 2022-11-01T17:19:14Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial fix for #76721.
Sets the paths right, so that running e.g.

dotnet run -r browser-wasm -c Debug --project src/libraries/System.Linq/tests/System.Linq.Tests.csproj --debug --host browser -p:DebuggerSupport=true

results in:

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.29
WasmAppHost --runtime-config C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle\WasmTestRunner.runtimeconfig.json --debug --host browser
Debug proxy for chrome now listening on http://127.0.0.1:65095/. And expecting chrome at http://localhost:9222/
Hosting environment: Production
Content root path: C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\System.Linq.Tests\Debug\net7.0\browser-wasm\AppBundle
Now listening on: http://127.0.0.1:65095
Debug proxy for firefox now listening on tcp://127.0.0.1:65096. And expecting firefox at port 6000 .

App url: http://127.0.0.1:9000/index.html
App url: https://127.0.0.1:65097/index.html

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Infrastructure-mono`
Milestone:	-

ghost · 2022-12-23T17:01:52Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js

src/mono/wasm/host/BrowserArguments.cs

Co-authored-by: Ankit Jain <radical@gmail.com>

ilonatommy · 2023-01-26T12:11:16Z

Earlier failures, when we combined arguments in JS from the url's query and runArgs.json, were caused by nodeJs that does not have fetch function in the version==14.18.
Previously, we never actually used fetch("runArgs.json") because the condition: if (queryArguments.length > 0) then do not fetch runArgs.json was always true.

src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js

…an be later overwritten.

.

radical

Looks good. I would suggest adding instructions on how to use this with library tests in docs, but that can be in a follow up PR too.

Good job, and thanks for your patience, and all the testing needed for this one! 👍

src/mono/wasm/test-main.js

radical · 2023-01-31T08:06:09Z

src/mono/wasm/test-main.js

-        if (!response.ok) {
-            console.debug(`could not load /args.json: ${response.status}. Ignoring`);
+    let runArgsJson;
+    // ToDo: runArgs should be read for all kinds of hosts, but


Can you please open an issue to track this?

ilonatommy · 2023-01-31T09:06:16Z

Looks good. I would suggest adding instructions on how to use this with library tests in docs, but that can be in a follow up PR too.

Good job, and thanks for your patience, and all the testing needed for this one! 👍

Like this? #77368

Co-authored-by: Ankit Jain <radical@gmail.com>

ilonatommy added 2 commits October 25, 2022 13:25

Removed fixed path separator + duplicated browser-wasm.

d43bdc4

Working fix.

913c484

ilonatommy added arch-wasm WebAssembly architecture area-Infrastructure-libraries labels Nov 1, 2022

ilonatommy requested a review from radical as a code owner November 1, 2022 13:33

ilonatommy self-assigned this Nov 1, 2022

ilonatommy mentioned this pull request Nov 1, 2022

[wasm] Improve experience of debugging library tests #76721

Open

8 tasks

ilonatommy marked this pull request as draft November 1, 2022 17:11

carlossanlop added area-Infrastructure-mono and removed area-Infrastructure-libraries labels Nov 1, 2022

ilonatommy added 4 commits November 2, 2022 13:20

Fix for different OutputPath conventions.

1d56d6d

Fixing the url printed on the console.

9b77570

ProcessQueryArguments in test-main.js forces debug to be the 1st arg.

7f1d5b4

Removing special case for WBT.

bd80440

build-analysis bot mentioned this pull request Nov 23, 2022

CI build failure: Build MacCatalyst x64 Release AllSubsets_Mono - XcodeBuildApp task failed unexpectedly - Could not find System.Runtime.Tests.app #78778

Closed

ghost closed this Dec 23, 2022

Merge branch 'main' into fix-paths-76721

114794d

ilonatommy reopened this Jan 11, 2023

build-analysis bot mentioned this pull request Jan 11, 2023

Tracking issue for CI build timeouts #76454

Closed

Merge branch 'main' into fix-paths-76721

9e5e6e6

build-analysis bot mentioned this pull request Jan 17, 2023

tracing/eventpipe/eventsourceerror/eventsourceerror/eventsourceerror failure #80666

Closed

runfoapp bot mentioned this pull request Jan 17, 2023

Infra improvements for Helix #68176

Closed

We cannot skip checking for missing browser-wasm.

8b42506

ilonatommy marked this pull request as ready for review January 23, 2023 07:26

Revert changes in the shipped targets and move them to tests targets.

0e79616

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 25, 2023

pavelsavara reviewed Jan 25, 2023

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js Outdated Show resolved Hide resolved

radical reviewed Jan 25, 2023

View reviewed changes

src/mono/wasm/host/BrowserArguments.cs Outdated Show resolved Hide resolved

ilonatommy and others added 2 commits January 25, 2023 14:52

Update src/mono/wasm/host/BrowserArguments.cs

41d8c15

Co-authored-by: Ankit Jain <radical@gmail.com>

Fetch does not work for node<18 => get rid of json.

b76bd9c

build-analysis bot mentioned this pull request Jan 26, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

ilonatommy and others added 2 commits January 26, 2023 16:42

Separated runtime args from app args for both hosts.

bda0ebb

Merge branch 'main' into fix-paths-76721

9a82e27

radical reviewed Jan 26, 2023

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Jan 26, 2023

Build fails with "eng/common/tools.sh: line 474: 537 Segmentation fault" #76759

Closed

ilonatommy added 5 commits January 27, 2023 09:59

Revert 7.0 file.

af46992

Focusing on enabling libs debugging for browser.

dae5d74

Should have been reverted with dae5d74.

12f069a

Fix CI lib tests: avoid referencing undefined properties.

a4b2857

In all the cases runArgs should be first populated by defaults that c…

39be370

…an be later overwritten.

ilonatommy requested review from radical, pavelsavara and maraf January 31, 2023 07:00

radical approved these changes Jan 31, 2023

View reviewed changes

src/mono/wasm/test-main.js Outdated Show resolved Hide resolved

radical reviewed Jan 31, 2023

View reviewed changes

ilonatommy mentioned this pull request Jan 31, 2023

[browser][config] Reading runArgs available only on browser #81416

Open

Update src/mono/wasm/test-main.js

ef66826

Co-authored-by: Ankit Jain <radical@gmail.com>

pavelsavara approved these changes Jan 31, 2023

View reviewed changes

build-analysis bot mentioned this pull request Jan 31, 2023

DataContractSerializerTests.DCS_MyPersonSurrogate_Stress failing in CI #35066

Open

ilonatommy merged commit befeec4 into dotnet:main Jan 31, 2023

ghost locked as resolved and limited conversation to collaborators Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][libs] Fix `WasmAppHost`, and `AppBundle` for library tests #77719

[wasm][libs] Fix `WasmAppHost`, and `AppBundle` for library tests #77719

ilonatommy commented Nov 1, 2022 •

edited

Loading

ghost commented Nov 1, 2022

ghost commented Nov 1, 2022

ilonatommy commented Nov 1, 2022

radical commented Nov 1, 2022

ghost commented Nov 1, 2022

ghost commented Dec 23, 2022

ilonatommy commented Jan 26, 2023

radical left a comment

radical Jan 31, 2023

ilonatommy Jan 31, 2023

ilonatommy commented Jan 31, 2023

[wasm][libs] Fix WasmAppHost, and AppBundle for library tests #77719

[wasm][libs] Fix WasmAppHost, and AppBundle for library tests #77719

Conversation

ilonatommy commented Nov 1, 2022 • edited Loading

ghost commented Nov 1, 2022

ghost commented Nov 1, 2022

ilonatommy commented Nov 1, 2022

radical commented Nov 1, 2022

ghost commented Nov 1, 2022

ghost commented Dec 23, 2022

ilonatommy commented Jan 26, 2023

radical left a comment

Choose a reason for hiding this comment

radical Jan 31, 2023

Choose a reason for hiding this comment

ilonatommy Jan 31, 2023

Choose a reason for hiding this comment

ilonatommy commented Jan 31, 2023

[wasm][libs] Fix `WasmAppHost`, and `AppBundle` for library tests #77719

[wasm][libs] Fix `WasmAppHost`, and `AppBundle` for library tests #77719

ilonatommy commented Nov 1, 2022 •

edited

Loading