Don't consider lvSpillAtSingleDef in WritesAnyLocation
#78181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #78023
|
tannergooding
commented
Nov 10, 2022
| LclVarDsc* const varDsc = m_compiler->lvaGetDesc(LclNum()); | ||
| return varDsc->IsAlwaysAliveInMemory(); | ||
| return varDsc->lvLiveInOutOfHndlr != 0; |
There was a problem hiding this comment.
Worked with @SingleAccretion on this fix.
The premise is that IsAlwaysAliveInMemory checks both lvLiveInOutOfHndlr and lvSpillAtSingleDef. The latter is only set in LSRA and shouldn't have any significance with regards to side effect checking since such spills can't interfere.
This solves the inconsistency between the check in lowering and the assert in codegen.
jakobbotsch
approved these changes
Nov 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #78023