Use helpers for implicit casts in importer #78279
Merged
+107
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWork in progress.
|
SingleAccretion
force-pushed
the
Implicit-Casts
branch
2 times, most recently
from
ed4dac1 to
ceb319a
Compare
Will call this enough, 0.03% -> 0.015%.
SingleAccretion
force-pushed
the
Implicit-Casts
branch
from
b95e24c to
d6f10c8
Compare
|
@dotnet/jit-contrib |
|
/azp run runtime-coreclr superpmi-asmdiffs, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failure was #79439. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the implicit casts helpers to simplify code.
Some MinOpts diffs because MinOpts didn't constant-fold the implicit casts, forcing explicit null check insertion.