-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache GenericTypeDefinition to improve perf #78288
Merged
jkotas
merged 9 commits into
dotnet:main
from
lateapexearlyspeed:lateapexearlyspeed-CacheGenericDefinition
Nov 22, 2022
Merged
Cache GenericTypeDefinition to improve perf #78288
jkotas
merged 9 commits into
dotnet:main
from
lateapexearlyspeed:lateapexearlyspeed-CacheGenericDefinition
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Nov 13, 2022
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFix #73860
|
jkotas
reviewed
Nov 13, 2022
steveharter
reviewed
Nov 16, 2022
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
There is a risk of activator cache and generic type definition cache colliding
I have pushed some changes:
|
jkotas
changed the title
Put GenericTypeDefinition into genericCache to try to improve perf
Put GenericTypeDefinition into genericCache to improve perf
Nov 20, 2022
jkotas
changed the title
Put GenericTypeDefinition into genericCache to improve perf
Cache GenericTypeDefinition to improve perf
Nov 20, 2022
jkotas
approved these changes
Nov 20, 2022
2 tasks
marek-safar
approved these changes
Nov 21, 2022
@lateapexearlyspeed Thank you for getting this started! |
This was referenced Nov 29, 2022
ghost
locked as resolved and limited conversation to collaborators
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Reflection
community-contribution
Indicates that the PR has been added by a community member
tenet-performance
Performance related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #73860