[release/7.0] Fix handling generic custom attributes #78304
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
MichalStrehovsky
added
the
Servicing-consider
|
@MichalStrehovsky / @jeffschwMSFT I don't see a Tactics approval email. Can one of you please send one? Today's the due date for merging December release servicing fixes. |
|
adding @agocke |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #78297 to release/7.0 Customer ImpactIt's not possible to reflection-inspect generic custom attributes that reference their T in the constructor or properties. Attempting to inspect them throws an exception. Generic attributes are new in .NET 7 and this bug constitutes a severely broken 7.0 scenario. TestingTargeted testing. CI. RiskLow. The fix is small.
|
|
This was approved via email, but Tactics is also asking if this should include tests. |
carlossanlop
added
Servicing-approved
|
Adding the blocked label until the test question gets addressed. |
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
@radical this file doesn't compile into Mono at all, let's save electricity and environment of unnecessary runs. |
lol my mistake! 👍 |
The question was answered via email: "the product change was validated with all generic attributes testing we have". Also, "ran the specific CoreCLR test manually and verified it's okay". |
|
But I'll wait for Tactics to reply on the email before merging. |
Sounds good, merge when ready. |
|
Tactics confirmed we're good to merge. Signed off by area owners. No OOB package authoring changes needed. CI failure is a timeout cancelation. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #78297 to release/7.0
/cc @MichalStrehovsky
Customer Impact
It's not possible to reflection-inspect generic custom attributes that reference their T in the constructor or properties. Attempting to inspect them throws an exception.
Generic attributes are new in .NET 7 and this bug constitutes a severely broken 7.0 scenario.
Testing
Targeted testing. CI.
Risk
Low. The fix is small.