Fix creation of pointer arrays #79433
Conversation
Creation of pointer arrays is on a similar plan to multi-dim arrays - we create them from a template type, but the template is slightly wrong. Previously, EETypeCreator would massage the bits into the correct shape, but now we mostly just copy the bits from the template. Use a more precise template for pointer arrays. Without this, the base size and element type of pointer arrays was slightly wrong. I'm also deleting the duplicated "use a special template for this one" logic.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsCreation of pointer arrays is on a similar plan to multi-dim arrays - we create them from a template type, but the template is slightly off. Previously, EETypeCreator would massage the bits into the correct shape, but now we mostly just copy the bits from the template. Use a more precise template for pointer arrays. Without this, the base size and element type of pointer arrays was slightly wrong. I'm also deleting the duplicated "use a special template for this one" logic. This should fix #79403 (it didn't repro for me locally, but I didn't try too hard because I just followed a hunch and saw the Cc @dotnet/ilc-contrib
|
Creation of pointer arrays is on a similar plan to multi-dim arrays - we create them from a template type, but the template is slightly off. Previously, EETypeCreator would massage the bits into the correct shape, but now we mostly just copy the bits from the template. Use a more precise template for pointer arrays.
Without this, the base size and element type of pointer arrays was slightly wrong.
I'm also deleting the duplicated "use a special template for this one" logic.
This should fix #79403 (it didn't repro for me locally, but I didn't try too hard because I just followed a hunch and saw the
MethodTablebeing wrong).Cc @dotnet/ilc-contrib