Rangelistmap with native eh free il throw on Linux #79471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is improving docs on the old scheme - Also remove the ngen specific logic
- still with the wrong locking though...
…the collectible handling characteristics
Now that it is profileable, there are tweaks to be made
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point). - Implement a fast path for computing the number of arguments to a method instead of using MetaSig. - Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine. - Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
…elying on [,) semantics and some were [,]
…ion with the other work in this branch, produces much more scalable EH performance
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variation on my range map changes #79021 which show really great scaling.
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same
14008
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same
30763
30828
30864
30808
30786
30842
30810
30828
30837
30852
30779
30740
/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/
david/ehperf.dll sw sync 10 single same
20314
/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same
196476
196324
196150
196011
196244
195697
196478
196497
196287
196402
196489
196419