Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Fix switch peeling flags propagation #79748

Merged

Conversation

jakobbotsch
Copy link
Member

Otherwise we could propagate overlapping flags that change meaning. Extracted from #79346.

Otherwise we could propagate overlapping flags that change meaning.
Extracted from early liveness PR.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 16, 2022
@ghost ghost assigned jakobbotsch Dec 16, 2022
@ghost
Copy link

ghost commented Dec 16, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Otherwise we could propagate overlapping flags that change meaning. Extracted from #79346.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @kunalspathak (this is one of those cases where we can end up sharing flags that overlap. I hit that here in #79346)

@jakobbotsch jakobbotsch merged commit 48edd27 into dotnet:main Dec 17, 2022
@jakobbotsch jakobbotsch deleted the fix-switch-peeling-flags-propagation branch December 17, 2022 09:10
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants