-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decommit memory as needed #79912
Decommit memory as needed #79912
Conversation
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
101c2a0
to
697d713
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also it would be nice to add a comment to delete_region
to specify the invariant which is when you return a region to the global region allocator, memory should be decommitted (unless it's large pages) and mark array (if committed).
2d2cea0
to
44450f1
Compare
Looks good to me. Regarding Maoni's comment, I wonder if we can add an assert to |
44450f1
to
3497400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
With these commits (2ca7cf7...6aaaaaa) aspnet apps crash at runtime in the benchmarks CI. I am flagging the PR which had the potential to explain it. Crank command if you can run with and without this PR changes:
|
This reverts commit 6da8e2a.
This reverts commit 6da8e2a.
This change makes sure:
Fixes #79882