Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HFA detection in Crossgen2 #80218

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Fix HFA detection in Crossgen2 #80218

merged 2 commits into from
Jan 9, 2023

Commits on Jan 5, 2023

  1. Fix HFA detection in Crossgen2 

    According to customer feedback some WPF apps are crashing on arm64
at runtime in debug mode when compiled with Crossgen2. Based on
the initial investigation by Anton Lapounov and with help from
Jan Vorlicek I have managed to identify that the problem is caused
by a mismatch between the native CoreCLR runtime and Crossgen2
w.r.t. identification of HFA types.

This change puts Crossgen2 behavior in sync with the CoreCLR
runtime. I have verified locally that this makes the GC ref map
for the method System.Windows.Media.PathGeometry.GetPathBoundsAsRB
identical with the runtime version and avoids the assertion failure
that was previously triggered in debug CoreCLR builds due to this
mismatch.

Thanks

Tomas
    @trylek
    trylek committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    92078b2 View commit details
    Browse the repository at this point in the history

  2. Add modulus checks for fields and runtime reference comment per Anton… 

    …'s PR feedback
    @trylek
    trylek committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9b43a8d View commit details
    Browse the repository at this point in the history