Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to build FunctionalTests test assets as tests #80874

Closed

Conversation

lambdageek
Copy link
Member

@lambdageek lambdageek commented Jan 19, 2023

They are just assemblies that can be referenced by other tests, not standalone tests, themselves.

Follow-up to #80391 to address apparent failures on the Android runtime-extra-platforms legs

They are just assemblies that can be referenced by other tests, not
standalone tests, themselves.
@lambdageek
Copy link
Member Author

/azp run runtime-extra-platforms

@ghost
Copy link

ghost commented Jan 19, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

They are just assemblies that can be referenced by other tests, not standalone tests, themselves.

Author: lambdageek
Assignees: lambdageek
Labels:

area-Infrastructure-libraries

Milestone: -

@lambdageek
Copy link
Member Author

cc @simonrozsival

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member Author

@simonrozsival Well this didn't work.

I'm now suspecting src/tests/build.proj. In particular AllRunnableTestPaths which eventually goes into BuildAllAndroidApp which might be building everything as an APK?? Although I haven't figured out exactly what gets into AllRunnableTestPaths, yet.

<Target Name="BuildAllAndroidApp" DependsOnTargets="GetListOfTestCmds;FindCmdDirectories">
<MSBuild
Projects="$(MSBuildProjectFile)"
Targets="BuildAndroidApp"
Properties="_CMDDIR=%(TestDirectories.Identity)"
Condition="'@(TestDirectories)' != ''" />
</Target>

@lambdageek
Copy link
Member Author

Closing in favor of #80909

@lambdageek lambdageek closed this Jan 20, 2023
@lambdageek lambdageek deleted the try-fix-android-functional-tests branch January 24, 2023 01:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant