JIT: have inliner use fgSplitBlockAfterStatement #80928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of moving pred list building before inlining, use the common block split utility instead of custom code. This does a better job of propagating IL offsets, and automatically handles pred list maintenance. Contributes to dotnet#80193.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsIn anticipation of moving pred list building before inlining, use the common block split utility instead of custom code. This does a better job of propagating IL offsets, and automatically handles pred list maintenance. Contributes to #80193.
|
|
@EgorBo PTAL No code diffs, some debug info diffs. |
|
Nice cleanup! I wonder how many other places we have where we do something that we already have a helper for. It also seems that |
EgorBo
approved these changes
Jan 20, 2023
44 tasks
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
In anticipation of moving pred list building before inlining, use the common block split utility instead of custom code. This does a better job of propagating IL offsets, and automatically handles pred list maintenance. Contributes to dotnet#80193.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of moving pred list building before inlining, use the common block split utility instead of custom code. This does a better job of propagating IL offsets, and automatically handles pred list maintenance.
Contributes to #80193.