JIT: update fgReplaceJumpTarget to maintain pred lists
#81246
Conversation
This is used some early phases; make it pred list aware. Contributes to dotnet#80193.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThis is used some early phases; make it pred list aware. Contributes to #80193.
|
|
@BruceForstall PTAL Seems like we also might be able to use this in place of |
| @@ -559,11 +557,17 @@ void Compiler::fgReplaceJumpTarget(BasicBlock* block, BasicBlock* newTarget, Bas | |||
| case BBJ_ALWAYS: | |||
| case BBJ_EHCATCHRET: | |||
| case BBJ_EHFILTERRET: | |||
| case BBJ_LEAVE: // This function will be called before import, so we still have BBJ_LEAVE | |||
| case BBJ_LEAVE: // This function can be called before import, so we still have BBJ_LEAVE | |||
There was a problem hiding this comment.
The changes in this function look fine, but also it seems weird BBJ_NONE/etc. case don't assert unreached.
There was a problem hiding this comment.
Let me fix this.
It's also a bit odd that even block has a reasonable jump kind this method can silently do nothing if block doesn't jump to oldTarget, but there are places we rely on this behavior right now.
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This is used some early phases; make it pred list aware.
Contributes to #80193.