Fix a couple of JsonConstructor bugs & clean up JsonParameterInfo implementation. #81842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Feb 8, 2023
...xt/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Small.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Feb 8, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonParameterInfo.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Feb 8, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonParameterInfo.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Feb 8, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Feb 8, 2023
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Feb 8, 2023
src/libraries/System.Text.Json/tests/Common/TestClasses/TestClasses.Constructor.cs
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
default-nullable-ctor-arg
branch
from
653a881 to
87f8218
Compare
krwq
reviewed
Feb 9, 2023
...libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/DefaultValueHolder.cs
Show resolved
Hide resolved
|
given this scenario might affect benchmarks, I'd recommend to run perf tests, otherwise LGTM |
krwq
reviewed
Feb 9, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonParameterInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 9, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonParameterInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Feb 9, 2023
krwq
reviewed
Feb 9, 2023
...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60082. Fix #68647.
Simplifies the
JsonParameterInfoimplementation using conventions already used inJsonTypeInfoandJsonPropertyInfo.