Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] Add wasi-experimental workload, wasiconsole template, and Wasi.Build.Tests #81849

Merged
merged 12 commits into from
Feb 23, 2023
Merged

[wasi] Add wasi-experimental workload, wasiconsole template, and Wasi.Build.Tests #81849

merged 12 commits into from
Feb 23, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 8, 2023 •
edited
Loading

  • Initial Wasi.Build.Tests, with some duplicated code between Wasi, and Wasm build tests. This is being cleaned in a separate branch for a follow up PR
  • Add a new wasiconsole template
  • WasmAppHost - add support to run with wasmtime

@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm labels Feb 8, 2023
@ghost ghost assigned radical Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, arch-wasm, wasi
Milestone: -

@radical
Copy link
Member Author

radical commented Feb 9, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Feb 9, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@garath
Copy link
Member

garath commented Feb 9, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@garath
Copy link
Member

garath commented Feb 9, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Feb 10, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Feb 10, 2023

/azp run runtime-wasm-optional

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical force-pushed the workload-wasi branch 2 times, most recently from 526c3cd to 4d0f7fe Compare February 23, 2023 07:59
@radical radical removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Feb 23, 2023
@radical radical changed the title [IGNORE][wasm] wasi: add workload packs, templates, and Wasi.Build.Tests [wasi] Add wasi-experimental workload, wasiconsole template, and Wasi.Build.Tests Feb 23, 2023
@radical radical marked this pull request as ready for review February 23, 2023 16:35
@radical radical marked this pull request as draft February 23, 2023 16:37
@radical radical marked this pull request as ready for review February 23, 2023 17:09
pavelsavara
pavelsavara reviewed Feb 23, 2023
View reviewed changes
eng/liveBuilds.targets
<LibrariesRuntimeFiles
Include="
$(LibrariesNativeArtifactsPath)dotnet.wasm;
$(LibrariesNativeArtifactsPath)dotnet.timezones.blat;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will clash here with my PR on dotnet.timezones.blat;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be merged before the snap, correct? You can change it once this is merged as you see fit.

...ono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadManifest.targets.in Show resolved Hide resolved
src/mono/wasi/Wasi.Build.Tests/BuildTestBase.cs Show resolved Hide resolved
src/mono/wasm/templates/templates/wasi-console/wasi-console.0.csproj Show resolved Hide resolved
src/tasks/WasmAppBuilder/wasi/EmitWasmBundleObjectFile.cs Show resolved Hide resolved
src/mono/wasm/host/wasi/WasiEngineHost.cs
@@ -0,0 +1,95 @@
// Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wasi host should be separate project and separate host.
There are dependencies which don't make sense for WASI like BrowserDebugHost

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss that. For now I want to have a single WasmAppHost which can run any of the projects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will depend on how we decide to eventually compose the workloads.

src/mono/wasi/Wasi.Build.Tests/BuildTestBase.cs Show resolved Hide resolved
src/mono/wasi/Wasi.Build.Tests/BuildTestBase.cs Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Feb 23, 2023
Closed
This was referenced Feb 23, 2023
Closed
Open
@radical
Copy link
Member Author

radical commented Feb 23, 2023

Failure is unrelated, and known.

@radical radical merged commit ef43934 into dotnet:main Feb 23, 2023
@radical radical deleted the workload-wasi branch February 23, 2023 23:36
@build-analysis build-analysis bot mentioned this pull request Feb 24, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@lewing lewing lewing approved these changes

@kg kg Awaiting requested review from kg

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @garath @lewing @pavelsavara