Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tracing/eventpipe/simpleprovidervalidation/ on wasm #81860

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Skip tracing/eventpipe/simpleprovidervalidation/ on wasm #81860

merged 1 commit into from
Feb 9, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 8, 2023

Fixes #81859

@radical radical added arch-wasm WebAssembly architecture test-failure labels Feb 8, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned radical Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81859

Author: radical
Assignees: -
Labels:

arch-wasm, test-failure
Milestone: -

LakshanF
LakshanF approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@radical
Copy link
Member Author

radical commented Feb 9, 2023

The failure is unrelated, and known.

@radical radical merged commit 865c94c into dotnet:main Feb 9, 2023
@radical radical deleted the fix-runtime-test branch February 9, 2023 02:59
@build-analysis build-analysis bot mentioned this pull request Feb 9, 2023
Closed
@radical radical mentioned this pull request Feb 9, 2023
Merged
kg added a commit that referenced this pull request Feb 9, 2023
@kg
Disable EnsureCleanEnvironment on wasm since it can't possibly work (#…
4570167 
…81893)

The related test is also skipped on CI thanks to #81860
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] Runtime test simpleprovidervalidation.sh failing on CI
2 participants
@radical @LakshanF