Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Use docker images without fixed version suffix #81933

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

carlossanlop
Copy link
Member

From this comment #81391 (comment) seems that we need to stop using the images with the specific hash+date in their name.

I made sure to match the strings we use in main for libraries, coreclr and source-build.

@ghost
Copy link

ghost commented Feb 10, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

From this comment #81391 (comment) seems that we need to stop using the images with the specific hash+date in their name.

I made sure to match the strings we use in main for libraries, coreclr and source-build.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM as long as tests pass

eng/common/templates/jobs/source-build.yml Outdated Show resolved Hide resolved
@carlossanlop
Copy link
Member Author

Good news: the unauthorized exception issues in arm and arm64 linux are gone

@carlossanlop carlossanlop merged commit 8bdf22a into dotnet:release/6.0 Feb 10, 2023
@carlossanlop carlossanlop deleted the MoreHelixQueueFixes6 branch February 10, 2023 16:23
@carlossanlop
Copy link
Member Author

The UserSecrets and IsolatedStorage issues are gone. There was one image that will need to get updated to a newer OS because it was using 16.04 so the failure did not go away. I'll submit a separate PR for that.

The other failure is a network issue stating the connection was reset by the peer. Only affected one test, and I haven't seen it affecting other tests (yet), so there's no issue for it.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants