Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cinc instead of csel when possible #82031

Merged
merged 12 commits into from
Apr 12, 2023
Merged

Use cinc instead of csel when possible #82031

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4d674aa
Use cinc instead of csel when possible
SwapnilGaikwad Jan 23, 2023
10b636f
Merge main
SwapnilGaikwad Mar 27, 2023
9fd643a
Add a separate node for cinc
SwapnilGaikwad Mar 27, 2023
c2481ad
Remove rebase leftover
SwapnilGaikwad Mar 27, 2023
1fbb2f2
Make GT_CINC as a BINOP
SwapnilGaikwad Mar 28, 2023
40970f4
Remove unnecessary assertion
SwapnilGaikwad Apr 4, 2023
446b0f9
Consume register holding cinc operand
SwapnilGaikwad Apr 6, 2023
4f53bb5
Merge main
SwapnilGaikwad Apr 11, 2023
68805e8
Fix cleanup of cinc nodes and incorporate review comments
SwapnilGaikwad Apr 11, 2023
c0164b4
Revert building RefPositions for cinc node
SwapnilGaikwad Apr 11, 2023
1c4f94f
Clean GTF flags from the prev node correctly
SwapnilGaikwad Apr 12, 2023
fcbc7b1
Merge main
SwapnilGaikwad Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/jit/codegen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,9 +875,9 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
void genCodeForCompare(GenTreeOp* tree);
#ifdef TARGET_ARM64
void genCodeForCCMP(GenTreeCCMP* ccmp);
void genCodeForCinc(GenTreeOp* cinc);
#endif
void genCodeForSelect(GenTreeOp* select);
void genCodeForCinc(GenTreeOp* cinc);
void genIntrinsic(GenTreeIntrinsic* treeNode);
void genPutArgStk(GenTreePutArgStk* treeNode);
void genPutArgReg(GenTreeOp* tree);
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/codegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4725,7 +4725,6 @@ void CodeGen::genCodeForCinc(GenTreeOp* cinc)
regNumber targetReg = cinc->GetRegNum();
regNumber srcReg = op->IsIntegralConst(0) ? REG_ZR : genConsumeReg(op);

assert(op->IsCnsIntOrI());
SwapnilGaikwad marked this conversation as resolved.
Show resolved Hide resolved
assert(prevDesc.oper != GT_OR && prevDesc.oper != GT_AND);
emit->emitIns_R_R_COND(INS_cinc, attr, targetReg, srcReg, JumpKindToInsCond(prevDesc.jumpKind1));
regSet.verifyRegUsed(targetReg);
Expand Down