Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][workloads] Backport UsingMobileWorkload change #82268

Merged

Conversation

steveisok
Copy link
Member

Backport of #77489

Adds the UsingMobileWorkload property along with a tighter check on when to import the aot task

Backport of dotnet#77489

Adds the UsingMobileWorkload property along with a tighter check on when to import the aot task
@ghost ghost assigned steveisok Feb 16, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@jeffhandley jeffhandley added area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 17, 2023
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this code already live in Current? I missed this was targeting release/7.0

@lewing
Copy link
Member

lewing commented Feb 17, 2023

should add the fixed condition to net6 too

@lewing lewing changed the title [workloads] Backport UsingMobileWorkload change [release/7.0][workloads] Backport UsingMobileWorkload change Feb 17, 2023
@lewing
Copy link
Member

lewing commented Feb 17, 2023

wasm failure is #82271

@steveisok steveisok requested a review from carlossanlop March 1, 2023 17:58
@steveisok
Copy link
Member Author

steveisok commented Mar 1, 2023

@carlossanlop this is a tell mode change. I'll bump the PR to hopefully get better CI results ;-).

@carlossanlop
Copy link
Member

@mmitche are you ok with merging this? Just want to confirm that this won't mess with the build flows with the servicing branch closed.

@mmitche
Copy link
Member

mmitche commented Mar 6, 2023

@mmitche are you ok with merging this? Just want to confirm that this won't mess with the build flows with the servicing branch closed.

Please wait until branding/checkins tomorrow.

@carlossanlop carlossanlop merged commit 8a7a2ea into dotnet:release/7.0 Mar 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants