Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test for compiler generated trim warning suppression issue #82957

Conversation

vitek-karas
Copy link
Member

This is adding a test for #82956 (currently assumes the wrong behavior).

Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:

  • As we share more source files between the tools it will be much easier to work in.
  • We already share test sources, so this makes it easy to run the modified test with all three tools at once (from one instance of VS)

This is adding a test for dotnet#82956 (currently assumes the wrong behavior).

Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:
- As we share more source files between the tools it will be much easier to work in.
- We already share test sources, so this makes it easy to run the modified test with all three tools at once (from one instance of VS)
@vitek-karas vitek-karas added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Mar 3, 2023
@vitek-karas vitek-karas added this to the 8.0.0 milestone Mar 3, 2023
@vitek-karas vitek-karas requested a review from sbomer March 3, 2023 21:51
@vitek-karas vitek-karas requested a review from marek-safar as a code owner March 3, 2023 21:51
@vitek-karas vitek-karas self-assigned this Mar 3, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 3, 2023
@ghost
Copy link

ghost commented Mar 3, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is adding a test for #82956 (currently assumes the wrong behavior).

Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:

  • As we share more source files between the tools it will be much easier to work in.
  • We already share test sources, so this makes it easy to run the modified test with all three tools at once (from one instance of VS)
Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Tools-ILLink

Milestone: 8.0.0

@ghost
Copy link

ghost commented Mar 3, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

This is adding a test for #82956 (currently assumes the wrong behavior).

Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:

  • As we share more source files between the tools it will be much easier to work in.
  • We already share test sources, so this makes it easy to run the modified test with all three tools at once (from one instance of VS)
Author: vitek-karas
Assignees: vitek-karas
Labels:

linkable-framework, area-Tools-ILLink

Milestone: 8.0.0

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vitek-karas
Copy link
Member Author

I created #83048 for the failures in mono wasm debugger. The rest of the failures are known issues.

@vitek-karas vitek-karas merged commit 27f781f into dotnet:main Mar 6, 2023
@vitek-karas vitek-karas deleted the TestForNestedCompilerGeneratedCodeSuppression branch March 6, 2023 21:56
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants