-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a test for compiler generated trim warning suppression issue #82957
Adds a test for compiler generated trim warning suppression issue #82957
Conversation
This is adding a test for dotnet#82956 (currently assumes the wrong behavior). Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages: - As we share more source files between the tools it will be much easier to work in. - We already share test sources, so this makes it easy to run the modified test with all three tools at once (from one instance of VS)
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsThis is adding a test for #82956 (currently assumes the wrong behavior). Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsThis is adding a test for #82956 (currently assumes the wrong behavior). Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I created #83048 for the failures in mono wasm debugger. The rest of the failures are known issues. |
This is adding a test for #82956 (currently assumes the wrong behavior).
Also adds a solution file which includes all three trim tools, illink, illink.analyzer and ilc. This brings several advantages: