Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Coreclr docs #83

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Update the Coreclr docs #83

merged 2 commits into from
Nov 18, 2019

Conversation

jashook
Copy link
Contributor

@jashook jashook commented Nov 18, 2019

  • Changes coreclr root references to runtime
  • Changes all bin/Product references to artifacts/bin/coreclr
  • Various cleanup in the how to build your product docs

trylek
trylek approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping the documentation up to date!

docs/coreclr/building/android.md Outdated Show resolved Hide resolved
@jashook jashook merged commit cd48ed3 into dotnet:master Nov 18, 2019
@jashook jashook deleted the coreclr_docs_overhaul branch November 18, 2019 17:21
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@jkotas jkotas jkotas approved these changes

@BruceForstall BruceForstall Awaiting requested review from BruceForstall

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jashook @jkotas @trylek @karelz @Dotnet-GitSync-Bot