-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] partial reversal of PR #82826 #83637
[browser] partial reversal of PR #82826 #83637
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThere is problem in Blazor E2E test with protecting the class It seems in some scenario the root file I believe that this PR would be enough revert of the original #82826
|
This comment was marked as outdated.
This comment was marked as outdated.
@maraf any idea why this is failing? If we understand the failures and can fix them, I think we should port this to the preview3 branch instead of #83664 in order to unblock runtime -> aspnetcore codeflow (CC @mmitche) Related: dotnet/aspnetcore#47110 |
Failures are not related. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
/backport to release/8.0-preview3 |
Started backporting to release/8.0-preview3: https://github.com/dotnet/runtime/actions/runs/4483993832 |
There is problem in Blazor E2E test with protecting the class
System.Runtime.InteropServices.JavaScript.LegacyExports
from trimming.It seems in some scenario the root file
ILLink.Descriptors.LegacyJsInterop.xml
is not available and the class is trimmed even if we still should have it.I believe that this PR would be enough revert of the original #82826
We should use it in case that we can't figure out better fix.